scanf not scanning

hello guys, i am facing the problem, it is a very simple one, but the solution is not striking right now, the following is the code that i have typed, but there is a problem in scanning the value of character variable 'chy', the compiler is not stopping to accept the value.
the scanf line which is bold and in italics is the one with the problem, i think so. following is the code.
-------------------------------------------------------------------------------------------------------
#include<stdio.h>

#include<math.h>
int main()
{
double pie,theth,dis,velo=0.0;

char chy;
char ty;
do
{

printf("\nEnter the angle theta: ");
scanf("%lg",&theth);

printf("\n Enter the angle pie: ");
scanf("%lg",&pie);

printf("\nEnter the velocity of the projectile: ");
scanf("%lg",&velo);

pie=3.1415927/180.0*pie;
theth=3.1415927/180.0*theth;

dis=2.0*velo*velo*cos(theth)*cos(theth)*(tan(theth)-tan(pie)/(9.81 * cos(pie)));

printf("\nThe Distance is: %g",dis);

printf("\nDo You whish for another calculations [Y|N]: ");
scanf("%c", &chy);

printf("\nthe valu of n and N is: %c, %c",chy,ty);
}while((chy != 144) || (chy != 78));

return 0;
}

-----------------------------------------------------------------------------------------------------------
please let me know about the problem.
thank you for your time and patience.
Regards
Harbir

I might be wrong, I haven't done C in a very long time. But shouldn't that be ch, and not C?

no, the line is correct, but i've found exactly the same problem from time to time, if i use scan in an if() statement, i also have the same problem with char.

why don't you try:

chy = getchar();

instead of your line?

I was just about to say the same thing. scanf() is a very fussy function. Sometimes, it just refuses to scan. To get single letters from input, I find getchar() to be much much better.

Cheers,
cgkanchi

Hmm a quick question.. if somebody were to insert more than one character, wouldn't the next chars be passed on to whatever other function would 'buy' them? This could result in an overflow. I think it does depend on the compiler because on some I did have that problem, while on others I didn't.

But yeah, your best bet would be to do a getchar(), it should simplify things greatly.

hi

here you go...cant use Characters like that........... use String instead .....or the .....getche() method ...getche() looks more ...cool :cool: ...you don't have to press Return after entering the Character..I have included both methods...and a few alteratio to the code hope you don't mind :)...the code i have altered or added i have made it Bold and Italics

It's been a long since i worked on C ..it was a good feeling after that long time......

.Code works on Turbo C/C++..... Visual C++ ....can't say about other compilers...

Code:

---

#include<stdio.h>
#include<string.h>
#include<math.h>
int main()
  {
    double pie,theth,dis,velo=0.0;
    char ch;

          do
          {

              printf("\nEnter the angle theta: ");
              scanf("%lg",&theth);

              printf("\n Enter the angle pie: ");
              scanf("%lg",&pie);

              printf("\nEnter the velocity of the projectile: ");
              scanf("%lg",&velo);

              pie=3.1415927/180.0*pie;
              theth=3.1415927/180.0*theth;

              dis=2.0*velo*velo*cos(theth)*cos(theth)*(tan(theth)-tan(pie)/(9.81 * cos(pie)));

                printf("The Distance is:%lg\n",dis);
 
                printf("\nContinue? Y/N: ");
                scanf("%s",&ch);
                //ch=getche();



            }while(toupper(ch)=='Y');

getch();
return 0;
}

---

--Good Luck--

AFAIK, getch() and getche() aren't ANSI C functions. Therefore, you are not guaranteed that they will work. I know for a fact that it doesn't work on gcc and that it works on Turbo/Borland C++.

Cheers,
cgkanchi

Thanx Guys,
the code works well with %s after including #inlcude<stdio.h>

cheers

Hi

Yes Antionline Herpetologist is right they are not ..i have always worked on Turbo C ++ that i sometimes forget that there are other Compilers as well and about the standard ANSI C functions.

The Above Code will work without them ...Just delete the Getch(); at the end ...its of no use there ..i write that as a habit .....otherwise the DOS window Dissapers without even letting me see the result....it's just there to stop it after the whole program is finished .

--Good Luck--

Quote:

---

Thanx Guys,
the code works well with %s after including #inlcude<stdio.h>

cheers

---

the code you've printed in your first post, already had "#include <stdio.h>" in it, so this makes no sense :(

Quote:

---

Originally posted here by cgkanchi
AFAIK, getch() and getche() aren't ANSI C functions. Therefore, you are not guaranteed that they will work. I know for a fact that it doesn't work on gcc and that it works on Turbo/Borland C++.

---

getch() and getche() (and some other console functions) are included in conio.h. But yes, they aren't ANSI C functions. And conio.h doesn't come with (original) gcc. However, MinGW port of gcc (and Dev-CPP and cygwin's gcc which uses MinGW) does have conio.h header file.

So if you have C code which uses getch() or getche() that works on Turbo/Borland C++ or VC++, just do #include <conio.h>, and it will work on MinGW and Dev-CPP.

Peace always,
<jdenny>

hi

Quote:

---

Originally posted here by lepricaun
the code you've printed in your first post, already had "#include <stdio.h>" in it, so this makes no sense :(

---

lol lepricaun he ment #include <String.h>.......not <studio.h>.....typing error..

Quote:

---

So if you have C code which uses getch() or getche() that works on Turbo/Borland C++ or VC++, just do #include <conio.h>, and it will work on MinGW and Dev-CPP.

---

Same is the case is with Turbo C++ ...you will have to #inclue <conio.h> to get them working.. :confused:...So what is the difference..sorry for my ignorance...the only C/C++ Compilers i have used are Turbo, Borland and Visul C++....

--Good Luck--

Sorry i ment #include<string.h>

ok, i get the point :) , i'm learning C myself at the moment, so thats the reason why i didn't saw you meant strings.h, but hey, at least i've learned something new from it now :lol:

all of the above replies makes sense but i have got the real reason why this isn't working! this is because u must be using Browland C++ 3.0 version of turbo c++, the compiler of this version is that the compiler gives problems sometimes for scanning the value with scanf().
what u have to do is to get a C compiler which will definitely work! i m sure about this!

hi akshayakrsh

First of all Welcome to AO...........

Yes Trubo C++ will always give you this problem of not scanning the character variable if used just after some other variable in this faschion......it will just ignore it and go to the next statement .........it would have scaned the same value if it would have been the first value you have scanned .....i have no idea why.......apart from changing the compiler.......more simple solution i think is to use string %s it solves this problem...or specify the index number ch[0] where to store the value......that solves this problem........I had encountered this problem in the very early days of my learning C and at that time it got me soooo pissed ........because i just couldn't make out what the problem was ..........so so now that he has brought up the issue i would too like to know the reason if anybody knows........

If a few people didn't understand what akshayakrsh and i am trying to say here is look at the following code

Code:

---


#include<stdio.h>
#include<conio.h>

void main()
{
        char ch;
        int num;


        printf("Enter Munber :");
        scanf("%d",&num);

        printf("Enter character : ");
        scanf("%c",ch);

        printf("The Number you entered was : %d",num);
        printf("The Character you entered: %c",ch);

getch();

Output
The Number you entered was :12
}

---

In the following code it wouldn't even wait for me to put in the character value ....just after putting the number and pressing enter it would show the result wouldn't wait at the character............and the strange thing is i don't find anything wrong with this code........

If i input the number after the character it would work fine.......as in the following code

Code:

---


        printf("Enter character : ");
        scanf("%c",ch);

        printf("Enter Nunber :");
        scanf("%d",&num);


---

The Solution to this is to use String instead of Character....

Code:

---


        printf("Enter Munber :");
        scanf("%d",&num);

        printf("Enter character : ");
        scanf("%s",ch);

---

Or specify the erray location while entering the character ch[0]...

Anybody have any idea why........ :confused:


And one thing more akshayakrsh........Some.People here generally don't appriciate bumping of very old threads until you have something useful to add......which i think you had here..........the thing is it is considered that if the thread is soo old the problem might have been solved by now.......If you have to post to a very old thread to add something to it.......... the Golden rule to Bump the thread first and then post ........keeps tham wondering ;)...........just a word of advice i know this thread is not that old .

And i would like to suggest you would want to remove your Complete address from the location.....because you got the whole thing there with house Number With Pin Code......this being a public site you never know we got quite a few stakers around here j/k.........or are you Expecting Fan-mails ;)


--Good Luck---