Again: help with Java program

This is a class in a program I am working on:

Code:

---

class ImageBox extends JFrame {
       
        JTextField filename = new JTextField(15);
        JLabel label = new JLabel("Save as: ", JLabel.LEFT);
        JButton capture = new JButton("Get the image");
        GridLayout layout = new GridLayout(2, 2);
        DataConnect dataconn = new DataConnect(999);
        byte[] image;
        int i = 0;
        String file;
       
       
        public ImageBox() {
                super("Save a screenshot");
               
                capture.addActionListener(new ActionListener() {
                        public void actionPerformed(ActionEvent evt) {
                                        dataconn.establishConnection();
                                        try {
                                               
                                                while (true) {
                                                        image[i] = dataconn.data_reader.readByte();
                                                        i++;
                                            }
                                         
                                           
                                        } catch (IOException e) {
                                            System.err.println("Exception: " + e.getMessage());
                                    }
                                        file = filename.getText();
                                       
                                       
                    }
            });
           
            JPanel pane = new JPanel();
            pane.setLayout(layout);
            pane.add(label);
            pane.add(filename);
            pane.add(capture);
           
            setContentPane(pane);
    }
   
    void applyWindowListener() {
           
    WindowListener l = new WindowAdapter() {
           
            public void windowClosing(WindowEvent e) {
                   
                    setVisible(false);
        }
    };
    this.addWindowListener(l);
    this.pack();
    this.setVisible(true);
   
    }
}

---

Why, when I click the capture button an exception is thrown that there was an event generated at an unknown source, although I have added an ActionListener?

euhm, no, there isn't supposed to be a ')' there, look at the end, it closes with '});' , notice the ')'. It compiles fine, it's just that damn exception that is thrown. I thought it would be a VM issue again so I changed the class to implement ActionListener and changed some stuff:

capture.addActionListener(this);

I also obviously created a public void actionPerformed() that is not inside the ActionListener declaration like above. Didn't solve anything.

Nm, you spacing was a little off in my browser and I matched the wrong } with it.

I mainly know c++, but did some java while in school so I'm a little rusty. Could this be the cause of your exception?

Quote:

---

try {
while (true) {
image[i] = dataconn.data_reader.readByte();
i++;
}

---

Seems like that would be a forever loop until it reads past the end of dataconn and then tosses an exception?

No, that's not the problem, dataconn is an instance of the DataConnect class (which I wrote), the DataConnect class is only used to establish a connection to transfer binary data.
It doesn't read past the end of anything, the server closes the connection when it has sent the data being received in the snippet you just quoted.

The problem is, like I said, and exception is thrown that an event at an unknown source has occured. It's not an exception that the compiler forces you to try/catch or declare that it can be thrown.

Full source code of the program can be found here: elhalf.com/Crat.java (client part) and elhalf.com/CratServer.java (server). You won't find that code in it, the code on my site works. I am adding a feature to take a screenshot on the remote computer and transfer it over a socket. But at least you can get an idea of what this program does.

The server may sever the connection, but how do you exit the while(true) loop? There is no break or return. Maybe it should be

try {
while (image[i] = dataconn.data_reader.readByte() )
i++;
}

Well you are probably correct, there may be other logic mistakes too in the entire program but that's not the point for now. The program doesn't get to that point so for now I first have to find the problem of the exception that is thrown. I'll download the latest sdk (I am using 1.4.2_01-b6 and the latest is 1.4.2_05 so it is most likely a vm or compiler issue.

Have you already fixed this?

Have you been running this through a good debugger? Or tried debugging print statements to check your program state and commenting out the code you think may be troublesome?

I have commented out the code that may cause trouble.

Code:

---

public void actionPerformed(ActionEvent evt) {
dataconn.establishConnection();
try {

while (true) {
image[i] = dataconn.data_reader.readByte();
i++;
    }
 
   
 } catch (IOException e) {
    System.err.println("Exception: " + e.getMessage());
    }
 file = filename.getText();


    }
    });

---

But it's strange, while there is no exception anymore when I remove actionPerformed's content the exception thrown has nothing to do with IO...

Please stop using your current VM build. The last problem you had was also (most likely) a VM issue. Remember that the 'b' in the name signifies a beta release. Please get a 1.4 release VM and try again.

Cheers,
cgkanchi

I have the latest stable VM (1.4.2_05) already as I thought that was the problem. Nothing is solved :(

Quote:

---

Originally posted here by el-half
I have commented out the code that may cause trouble.
[...]
But it's strange, while there is no exception anymore when I remove actionPerformed's content the exception thrown has nothing to do with IO...

---

How about a catch block that reads:

Code:

---

try {
  blahblah...;
} catch (Exception e) {
  System.out.println("Exception Thrown: "+ e.getClass().getName() +");
  System.out.println("Message: "+ e.getMessage());
}

---

Should help you understand which exception is being thrown.

Thanks, I now found out a NullPointer exception is thrown, so something is wrong with the IO stuff after all. I think.
/me is unable to fix it.

NullPointerException is probably being thrown by that DataConnect class. I'd help, but DataConnect isn't a part of the Java API. I'd assume reading the third party docs for it might help you a bit.

DataConnect is a class I wrote:

Code:

---

class DataConnect {    //class for transfer of image
       
        Socket socket = null;
        BufferedInputStream buffer = null;
        DataInputStream data_reader = null;
        String address = "192.168.1.3";
        int PORTNUM;
       
        public DataConnect(int port) {
            PORTNUM = port;
    }
   
    void establishConnection() {
           
            try {
                    socket = new Socket(address, PORTNUM);
                    buffer = new BufferedInputStream(socket.getInputStream());
                    data_reader = new DataInputStream(buffer);
        } catch (IOException e) {
                System.err.println("Exception: " + e.getMessage());
                System.exit(1);
        }
    }
}

---

The exception should give you line numbers, so you should be able to figure out what line in which file is generating the exception. You might also try something like:

Code:

---

try {
  i=0;
  while ((image[i++] = dataconn.data_reader.readByte()) != -1) {
        // Read data in while it's not EOS
  }
} catch (Exception e) {
  System.out.println("Exception Thrown: "+ e.getClass().getName() +");
  System.err.println("Exception: " + e.getMessage());
}

---