How's it looking?

[Kamikaze Badger]

On the program I've being working on for around a month now(I'm lazy...), I've finally got it towards final coding stages. Could someone please post any bugs and stuff they see in the raw code?

#include <iostream.h>
#include "Defs.h"

using namespace std;

long lnTrillion = "1000000000000";

int main();
 {
     cout << "Welcome to the Burn-A-Natar 3000! Type in anything to" << endl; <<
     "continue, or \"exit\" to quit: " << endl; <<;
     
     cin >> INTRO_ANSWER;
     
     if (INTRO_ANSWER == INTRO_COMPARE)
      {
          
          do 
             ( int z;
              z = lnTrillFunc ( .0000000000000000002 , .0000000000000000002 );
              cout << "We're at: " << z << " right now."; )
              
          while ( z != lnTrillion );
      }
      
      else
      
          {
              cout << "Goodbye!";
              
                  return(0);
          }
      }
          

    
     double dblTrillFunc ( double dblDeciOne , double dblDeciTwo );
   
   {
       long lnTrillResult;
       
       /* double dblDeciOne(.000000000000000000002);
       double dblDeciTwo(.000000000000000000002); */
       
       lnTrillResult = ( dblDeciOne * dblDeciTwo );
       
       return(lnTrillResult);
   }

Defs.h:

#define INTRO_ANSWER
#define INTRO_COMPARE "exit"

[chsh]

Originally posted here by Kamikaze Badger
On the program I've being working on for around a month now(I'm lazy...), I've finally got it towards final coding stages. Could someone please post any bugs and stuff they see in the raw code?

For starters, in the do loop you have z = lnTrillFunc, but the function is defined as dblTrillFunc. There also doesn't seem to be a good reason to use Defs.h.

[sec_ware]

Hi

I am sorry, but is it just me, or do others also have the impression that this piece
of code won't even compile? And if it does, with what kind of compiler?
First, if you use the std, include <iostream> (without the h). Second,
you cannot assign a char[1?] to a long (lnTrillion). Third, use int main(){
instead of int main(); {. Remove the ; after the first endl; Do not stop
the cout with a "<<", you cannot cin on a preprocessor variable, ...

And so on. Please, work on it until it at least compiles. Or don't you have available
a compiler? If not, I recommend gcc[1] for linux or dev-cpp[2] for windows.

Cheers

[1] http://gcc.gnu.org/install/binaries.html
[2] http://www.bloodshed.net/devcpp.html

[chsh]

Originally posted here by sec_ware
I am sorry, but is it just me, or do others also have the impression that this piece
of code won't even compile?

Not on my box anyway. 'tis very broken, much of it syntactically, but some of it logically as well.

weird.cpp:8: invalid conversion from `const char*' to `long int'
weird.cpp:11: parse error before `{' token
weird.cpp:14: syntax error before `>>' token
weird.cpp:20: ISO C++ forbids declaration of `z' with no type
weird.cpp:20: `lnTrillFunc' was not declared in this scope
weird.cpp:21: syntax error before `<<' token
weird.cpp:30: parse error before `{' token
weird.cpp:34: ISO C++ forbids declaration of `lnTrillResult' with no type
weird.cpp:34: `dblDeciOne' was not declared in this scope
weird.cpp:34: `dblDeciTwo' was not declared in this scope
weird.cpp:35: parse error before `return'

IOW, broken as hell.

First, if you use the std, include &lt;iostream&gt; (without the h).

To elaborate, the .h includes for the standard headers is deprecated. GCC 3.2.2 gives you a warning if you add the .h:

This file includes at least one deprecated or antiquated header. Please consider using one of the 32 headers found in section 17.4.1.2 of the C++ standard. Examples include substituting the &lt;X&gt; header for the &lt;X.h&gt; header for C++ includes, or &lt;sstream&gt; instead of the deprecated header &lt;strstream.h&gt;. To disable this warning use -Wno-deprecated.

[sec_ware]

Hi

Since I am in a good mood, eating excellent tagliatelli with gorgonzola sauce,
and this will be my junior member post, I corrected the errors and modified the
source code a little bit (because I really could not get a meaning out of it).
Here it goes:

#include <iostream>
#include <string>
using namespace std;

#include <math.h>
#include "Defs.h"


double dblTrillFunc ( double dblDeciOne , double dblDeciTwo );
double lnTrillion = 1.0e+12;

 

int main()
 {
	double z;
	long counter;

     cout << "Welcome to the Burn-A-Natar 3000! Type in anything to" << endl <<   "continue, or \"exit\" to quit: " << endl ;
     
     cin >> INTRO_ANSWER;
     

     if (strcmp(INTRO_ANSWER,INTRO_COMPARE))
      {
		 counter=0;
         z= 1.0000000000000;
		 do {
              
              z = dblTrillFunc ( 1.002 , z );
              cout << "Step: " << counter << ". We're at: " << z << " right now." << endl;
              
			  counter++;

		 } while ( fabs(z - lnTrillion)/lnTrillion<1.0 );
		 cout << "Hey, using interests of interests (and no fees), we reached 1 Trillion $ in " << counter/365 << " years!" << endl;
    	 cout << "And this, starting with 1$ and an daily conformal interest of 0.002." << endl;
      }
      
      else
      
          {
              cout << "Goodbye!";
              
                  return(0);
          }

	    return(0);
      }
          

    
     double dblTrillFunc ( double dblDeciOne , double dblDeciTwo )
   
   {
       double lnTrillResult;
       
       /* double dblDeciOne(.000000000000000000002);
       double dblDeciTwo(.000000000000000000002); */
       
       lnTrillResult = ( dblDeciOne * dblDeciTwo );
       
       return(lnTrillResult);
   }

and the Defs.h

//#define INTRO_ANSWER
char INTRO_ANSWER[1024]; // yeah I know, I am sorry ... :D
#define INTRO_COMPARE "exit"

Cheers


P.s. If you actually want something like arbitrary precision while doing
calculations, check out MAPM[1].


[1] http://www.tc.umn.edu/~ringx004/mapm-main.html

[whizkid2300]

double dblTrillFunc ( double dblDeciOne , double dblDeciTwo );

Just a quick look over, on that line, you don't want a semi-colon at the end of the line. When you are actually defining your Functions, you don't put a semi-colon after your declaration.

You only use a semi-colon, when you are stating it as a prototype, and when you are actually making a call to it.

[Kamikaze Badger]

Ok, did some work on it with the help of you guys and guys from other forums, and here's the updated(and heavily fixed) code:

#include <iostream>
#include <string>

using namespace std;



double dblTrillFunc ( double dblDeciOne , double dblDeciTwo )
   
   {
       //long lnTrillResult;
       
       /* double dblDeciOne(.000000000000000000002);
       double dblDeciTwo(.000000000000000000002); */
       
       double lnTrillResult = ( dblDeciOne * dblDeciTwo );
       
       return(lnTrillResult);
   }


string intro_answer;

string intro_compare = "exit";

long lnBillion = 1000000000;

double z;

int main()
 {
     cout << "Welcome to the Burn-A-Natar 3000! Type in anything to" << endl << \
"continue, or \"exit\" to quit: " << endl;
     
     cin >> intro_answer;
     
     if (intro_answer != intro_compare)
      {   
          do 
             {
              z = z + dblTrillFunc ( .0000000000000000002 , .0000000000000000002 );
              cout << "We're at: " << z << " right now.\n";
             }    
              
          while ( z < lnBillion );
      }
      
      else
      
          {
              cout << "Bye";
              
                  return(0);
          }
      }

That compiles, but with the result of z, it also outputs 4e-blahblah. Anyone know what the reason is?




And I wrote all this in Dev-C++. As you can see, my skills are advancing as I read more of the C++ tutorial at cplusplus.com.

[sec_ware]

Hi

Two comments on the code
1. always initialise variables to be on the "safe side": double z=0.0;
2. always return a value, if your function has a non-void return type.

	  return(0);
} // int main(){

Concerning your question: "outputs 4e-38":

A number like 1000 can be written as 10^3 (ten to the power of 3),
another notation is 1e+3 (three 3 zeroes after the 1).
A number like 0.001=1e-3 (if you shift the dot to the right 3 times, you get "1.0").
"cout" by default uses the "1e-3"-notation.

In your case: .000000000000000000002 = 2e-19.
And the following calculation:
.000000000000000000002*.000000000000000000002 =
2e-19 * 2e-19 = 4e-38.


Cheers