Can't find an error in the code

[nightcat]

function update_error_reasons ($hostid, $hostname, $error_reason)
{
$db_server = '';
$db_user = '';
$db_pwd = '';
$db_name = '';

$db_link = @mysql_connect($db_server, $db_user, $db_pwd);
$database = @mysql_select_db($db_name, $db_link);

$update_error_reasons = mysql_query ("
update server_error_reasons set error_reasons = $error_reason
where
hostid = $hostid
and
hostname = $hostname;");
}


Hi guys I don't seem to be able to find an error in this function, yet it doesn't update the table

Any ideas?

[morganlefay]

here ???

hostname = $hostname;");

2 semi colons??

MLF

[nightcat]

The first semicolon is a part of a SQL statement
"update server_error_reasons set error_reasons = $error_reason
where
hostid = $hostid
and
hostname = $hostname;"

The problem is that this function is supposed to update a table but it doesn't

[morganlefay]

Usually I can figure out where to look by the error it spits out when I run the script...

Could be a misspelled username\passowrd\server\db....could be a permissions error...could be a link problem...

do any other updates work??


Personally I dont use MYSQL....

MLF

[nihil]

I seem to recall from years ago that the hostname had to be mysqlhost for some reason or other?

[nightcat]

I seem to recall from years ago that the hostname had to be mysqlhost for some reason or other?

It's different hosts And theres only a couple of thousands of them

[nightcat]

Seems there was another error in another part of the system. Took me half an hour to explain it to my boss as well

Wouldn't have noticed it if it wan't for him though

[steve.milner]

Does it need a "commit;" ?

Steve

[steve.milner]

Oooooo could this be it (I'm not familiar with the prog language but this rang a bell:

$update_error_reasons = mysql_query ("
update server_error_reasons set error_reasons = '" || $error_reason ||
'" where
hostid = '" || $hostid ||
"' and
hostname = '" || $hostname || "';");

Where || is the concatenate operator. Note the singe quote ' next to the double quotes " to ensure your SQL read correctly

[SirDice]

One thing I can think of.. Perhaps there's no entry with that particular $hostid and $hostname. Then there would be nothing to update because the where clause fails.