C/C++ newb program(need help)

I am new to programming all together and was referred to this site so as I could ask a question about a program I am trying to make(keep in mind this is a very simple program to you guys probably).

(done in C/C++)

#include <iostream.h>
#include <stdio.h>
#include <string.h>
#include <windows.h>
#include <stdlib.h>

int main()
{
bool exitProg = false;
while(exitProg == false)
{
char mainChoice;
char inputChar[1000], outputChar[1000];
int inputInt[1000], outputInt[1000];
for(int b = 0; b <= 999; b++)
{
inputInt[b] = 0;
outputInt[b] = 0;
}
int mod = 0;
int e = 0;
int d = 0;
printf("Welcome to Dencoder, please type the letter of your selection:\n");
printf("a. Encode Message \nb. Decode Message\nc. Exit Program\n");
cin >> mainChoice;
switch(mainChoice)
{
case 'a':
printf("\n\nPlease enter your message you want encoded:\n");
scanf("%s", &inputChar);
printf("\nPlease enter your modifier(a number, 1-100 to help better encode your message):\n");
cin >> mod;
//scanf("%d", &mod);
printf("\nYour encoded message is:\n");
do
{
outputInt[e] = atoi("inputChar[e]") + mod;
if(inputInt[e] = '\0')
{
outputInt[e] = '\0';
}
printf("%d ", &outputInt[e]);
e++;
}while(inputChar[e] != '\0');
printf("\n\n\n\n");
break;
case 'b':
break;
case 'c':
exitProg = true;
break;
}
}
return 0;
}

ok I need you to ignore the case b and case c for now I am just trying to get it to encode, but whenever I try that, it outputs huge numbers for my outputInt. it always outputs numbers like 12 thousand or so. and if you don't know what the atoi() command is, it takes a char's ascii number and puts it into an integer format. please respond to this, it is bugging the hell out of me and I can't figure out why it is outputting numbers like 1280049 or other high numbers like that.

http://www.cs.wustl.edu/~schmidt/C++/
http://www.cprogramming.com/

check those links out, maybe they can help. I dont know much about programing in C/C++ because i'm majoring in Computer Engineering and we only are required to take a C class, and also I never bothered to learn on my own. I'll prolly start some day once i'm done with all the overwhelming classes i'm in. Good Luck with those links and also look around AO cuz i'm sure there's quite a few well written tutorials by some of our members.

peace

Thanks, I have it all worked out now.

Quote:

---

Thanks, I have it all worked out now.

---

Be a darling and tell us what the problem was, dont know too much about programming my self but learning is always fun. Glad you found a solution to your problem.

Dwcnmv,

Are you doing c/c++ now? I would suggest you to restrict from clubbing the languages(though C++ is from C, it is advanced). My suggestions for the above code:

a) for getting the ascii no. (in C itself) you could have used
printf("%d",inputChar[e])--prints the ascii char of the letter stored
if used as "%c" will show the character

b) From the efficiency point of view, you can use gets() function to store the text you enter. The gets() is very easy.

The URLs following can be useful:
www.cprogramming.com (a must mention as mentioned already)
www.programmersheaven.com
www.freeprogrammingresources.com
www.oopweb.com

Chokks.

I took your advice and just set it to using 'printf("%d ", inputChar[e] + mod);' this works fine, I don't know if it works for turning ints into a char, but the hard part is getting all the numbers into it, that is the part of the code that is freezing(but compiling without warnings or errors).

Well I have redone it quite a bit and I have the decode part done. My only problem is that, it still isn't working :). The code itself I keep looking at and I can't find anything wrong, but whenever I run the program when I try to decode something, and I enter in a number and start to enter the second one, the program freezes and it pops up an error and says would you like to send error report? The program compiles fine, but for some reason it isn't working.
Here is the code:

#include <iostream.h>
#include <stdio.h>
#include <string.h>
#include <windows.h>
#include <stdlib.h>

int main()
{
bool exitProg = false;
do
{
int t = 0;
int p = 0;
char mainChoice;
char inputChar[1000], outputChar[1000];
int inputInt[1000], outputInt[1000];
for(int b = 0; b <= 999; b++)
{
inputInt[b] = 0;
outputInt[b] = 0;
}
int mod = 0;
int e = 0;
int d = 0;
printf("Welcome to Dencoder, please type the letter of your selection:\n");
printf("a. Encode Message \nb. Decode Message\nc. Exit Program\n");
cin >> mainChoice;
switch(mainChoice)
{
case 'a':
printf("\n\nPlease enter your message you want encoded(use a _ for spaces):\n");
scanf("%s", &inputChar);
printf("\nPlease enter your modifier(a number, 1-100 to help better encode your message):\n");
cin >> mod;
printf("\nYour encoded message is:\n");
do
{
printf("%d ", inputChar[e] + mod);
e++;
}while(inputChar[e] != '\0');
printf("\n\n\n\n");
break;
case 'b':
printf("Enter the numbers of the message you want decoded(press enter after each number and type '-1' when done):\n");
for(t = 0; t != -1; t++)
{
scanf("%d\n", inputInt[t]);
if(inputInt[t] == -1)
{
t = -1;
}
}

printf("Enter the modifier of our message:\n");
cin >> mod;
for(p = 0; p != '\0'; p++)
{
inputInt[p] = inputInt[p] - mod;
}
do
{
int i;
for(i = 32; i <= 126; i++)
{

if(inputInt[e] == i)
{
outputChar[e] = i;

}

}
if(outputChar[e] == 95)
{
outputChar[e] = 32;
}
e++;
}while(inputInt[e] != '\0');
printf("\nHere is your decoded message:");
printf("\n%s", outputChar);
cout << endl << endl << endl << endl;
break;
case 'c':
exitProg = true;
break;
}
}while(exitProg == false);
return 0;
}

Someone figure this out, cause I am really confused. :p

can you please be more specific about where your program crashes..

I am assuming this is the piece of code though
scanf("%d\n", inputInt[t]);

remove the \n so it reads
scanf("%d", inputInt[t]);

also you need change the the code that reads in your text from
scanf("%s", &inputChar);
since inputChar is a character array you do not neet the & in front, and for better code that you can use spaces I would actually change it to:
getline(inputChar,1000);

now it will read up to 1000 characters includeing spaces and stop only when you hit return, it also limits the number of chars to 1000 max so that you cant be buffered overflowed(not that your using this as enterprise code but practicing safe programming is good practice)

Ok, well I did the things you said, and yea I saw that those are more effecient/better, but I am still having the problem that it doesn't work. It is freezing when you try to enter the numbers you want decoded, I enter the first one and it freezes, what is wrong with it? Here is the program if you want to run it:
http://home.comcast.net/~dwcnmv/encoder.exe
This is getting really frustrating.


[glowpurple]Hello World.[/glowpurple]
[gloworange]Hello World.[/gloworange]
[shadow]Hello World.[/shadow]
[pong]Hello World.[/pong]
[blur]Hello World.[/blur]
[flip]Hello World.[/flip]
(wanted to test the different types of message text on the forum)

ok change

scanf("%d\n", inputInt[t]);

to

scanf("%d", &(inputInt[t]));

so are you just practicing making a caeser cipher?

What is a caeser cipher?

(in a nut shell):
a caeser cipher is just a simple form of encryption. Basically its just what you have. You have text which is called 'plain text' and you apply a shift of N characters then you get the enciphered text which you send to someone who then applies -N to get the plain text back.

so did that solve your problem?

Well, from looking at your work why are you using c and c++ statements. I would suggest either using one or the other. the cin statement in C++ is the equal to a scanf in C. Is this a C program or a C++ program. You seem very :confused:

1) If this is a C++ app then use C++ header files ex: #include <iostream>
the dot h at the end of the header files states that it's a C header file C++ header files don't
have an extension.

2) That's the reason it's not working you have C++ statements inside a C program
cout is a C++ statement and is the same as a printf in C :cuss:

Hope this helps

a cesear cipher is a cipher that shifts the letters down a number of spaces ABCD for example shift a lets say three spaces it would then be a D. So every occurence of the letter A would be replaced with a letter D and so on etc.........

Good try though but at first glance I would say you found it in a cracker jack box and wonders why it doesn't work :duh:

i agree with phaza but if you just use #include <iostream> (because you want to write all your code in C++) make sure your next line or something is using namespace std; Anyways you should just stick with one programming language throughout your program :) there is a difference between C and C++. You can still type #include <iostream.h> in a C++ program, but it is better to do it like this:

Code:

---

#include <iostream>
using namespace std;

int main (void)
{
      using std::cout;
      using std::endl;
      std::cout << "1 4/|\ 4 1337 |>r0gr4m3r" << std::endl;
      return 0;
}

---

you dont need to do the std::cout or std::endl stuff because when you type in using namespace std; you are using a using directive (kinda funky sounding)...Anyways, thought i might just teach you a little bit of C++ :) while we are talking about differences between C and C++

my thoughts too.

yeah by the way why is this thread here it's not security related

I saw your code. Lot of variables used. Some lines can be cut down.But for timebeing let us have the same and discuss.Have you noticed this in your code;

printf("%d ", inputChar[e] + mod);

You are adding the char with a value but this affects only the display. The value stored in the array will not get changed to the sum.

for example: if I enter 'a' and mod as 20- it prints as 97+20=117 but still the value of the array remains only 97. it should be changed to 117 which only will then deduct the mod while you decode. Or else you will not get the required answer.

Have you heard of cryptography? It means translating plain text into scrumbled text in order to make the text unintelligible to unauthorised persons who view it. By the example encoding and decoding your objective may be that.

"Ceaser" is said to be the first in the list of using cryptography-so his algorithm of crytography is said to be 'Ceaser Cipher'. Nothing to worry. You have got many new algo. now. You can find more information about these in our dicussion forum or in google.

Chokks

Ok, well..... First.... the reason it is in here and it isn't security related is because a guy I met said that I should go here if I have questions with programming and stick in the forum. Even though it's security related I thought that you might be able to help.
Second... as for the switching between printf and scanf, I think I finally got that out of my system, lol I was just doing it with whichever one I felt like typing at that moment.
umm....
Also the reason why I just have it printf("%d", inputChar[e]+mod); is because I don't need it later. I guess if I needed it later then I could have put it into the array, but I don't so yea.....
Ok, but yea i've gotten the program to work, I took and went through all the steps and applied messages to see if they were working, and I figured out it wasn't displaying right.. it was receiving the numbers ok and translating them, just not displaying them. So I got that done, but if you want to you can try it at:
http://home.comcast.net/~dwcnmv/Encoder.exe

Yea, this whole program was just practice, i've read a beginner C book and I am running on just that, so I need to find some more books.

I think now I am going to try and make something harder, what is another simple type of encryption (I say simple cause I could probably write something to break the first one, lol), but yea what is another simple type of encryption?(that I could do in C++)

Was also thinking of making a binary translator, but it makes it really hard because you can't copy out of the command prompt if they are big outputs that you give to someone.