Can't find an error in the code

function update_error_reasons ($hostid, $hostname, $error_reason)
{
$db_server = '';
$db_user = '';
$db_pwd = '';
$db_name = '';

$db_link = @mysql_connect($db_server, $db_user, $db_pwd);
$database = @mysql_select_db($db_name, $db_link);

$update_error_reasons = mysql_query ("
update server_error_reasons set error_reasons = $error_reason
where
hostid = $hostid
and
hostname = $hostname;");
}


Hi guys I don't seem to be able to find an error in this function, yet it doesn't update the table :(

Any ideas?

here ???

hostname = $hostname;");

2 semi colons??

MLF

The first semicolon is a part of a SQL statement
"update server_error_reasons set error_reasons = $error_reason
where
hostid = $hostid
and
hostname = $hostname;"

The problem is that this function is supposed to update a table but it doesn't :(

Usually I can figure out where to look by the error it spits out when I run the script...

Could be a misspelled username\passowrd\server\db....could be a permissions error...could be a link problem...

do any other updates work??


Personally I dont use MYSQL....

MLF

Does it need a "commit;" ?

Steve

Oooooo could this be it (I'm not familiar with the prog language but this rang a bell:

$update_error_reasons = mysql_query ("
update server_error_reasons set error_reasons = '" || $error_reason ||
'" where
hostid = '" || $hostid ||
"' and
hostname = '" || $hostname || "';");

Where || is the concatenate operator. Note the singe quote ' next to the double quotes " to ensure your SQL read correctly

I seem to recall from years ago that the hostname had to be mysqlhost for some reason or other? :confused:

Seems there was another error in another part of the system. Took me half an hour to explain it to my boss as well :)

Wouldn't have noticed it if it wan't for him though :)

Quote:

---

Originally Posted by nihil

I seem to recall from years ago that the hostname had to be mysqlhost for some reason or other? :confused:

---

It's different hosts :) And theres only a couple of thousands of them :(

One thing I can think of.. Perhaps there's no entry with that particular $hostid and $hostname. Then there would be nothing to update because the where clause fails.

Are you still having this issue?

What error is tossed?

I'm assuming the from variables were stripped by you, and that they are ALL right?

Can you have a variable, update_error_reasons, thats the same name as a function?

Is this perl btw?

You use plural and singular in spots. Verify those are all correct.

I'd probably add some screen output statements to verify that the input variables are good.

Its been a while for me and mysql/perl, but do you need to execute the statement or does it do that inside the mysql_query function?

I'm assuming PHP? I see a couple of potential problems...try this:
1) Picky thing for me, when you are doing SQL, make the SQL key words in ALL CAPS, it makes it easier to read
2) I think your query might be failing due to quoting...regardless, the code i gave you will tell you why it is failing
3) I hope you sanitized your input before calling that...

Code:

---

function update_error_reasons ($hostid, $hostname, $error_reason)
{
$db_server = '';
$db_user = '';
$db_pwd = '';
$db_name = '';

$db_link = mysql_connect($db_server, $db_user, $db_pwd);
mysql_select_db($db_name);

$result = mysql_query($error_reason, $db_link);
if(! $result) {
    echo mysql_error();
// Note, don't do above in a production environment, I usually surround this with debugging code, but am trying to keep it simple here
} //end if
} // end function


$query = "UPDATE server_error_reasons SET error_reasons = '" . $error_reason . "WHERE hostid = '" . $hostid . "' AND hostname = '" . $hostname . "'";

$update_error_reasons("foo2", "foo", $query);

---

Not really groking what you were doing at the end, but I did the best I could with what you had...

Quote:

---

Originally Posted by SirDice

One thing I can think of.. Perhaps there's no entry with that particular $hostid and $hostname. Then there would be nothing to update because the where clause fails.

---

That was the problem I found. There were no values inserted in the table. I made a mistake in another query, which was supposed to automaticaly insert the necessary values from another table.

I guess the fact that I haven't touched PHP in almost 2 years might have something to do with me being slopy :(

Thanks everyone for their replies though :)