Sounds to me that you did pretty good.

The ATI and P4 2.8 will keep up with a lot of games.
The 512mb will be nice, however if you start doing a lot of intensive stuff on the LAN i.e webserver, fileserver etc then I would upgrade to 1gb ram.